adoptium / api.adoptium.net

Adoptium API 🚀

https://api.adoptium.net

Apache License 2.0

33 stars 26 forks source link

Add two new endpoints and normalize #1013

Closed xavierfacq closed 5 months ago

xavierfacq commented 5 months ago

Changes have been done on paths:

MOVE /available_releases is now /available/releases (deprecated with a 301 redirect to the new location)
ADD /available/architectures
ADD /available/operating-systems

Question: Do we use /available/operating-systems or /available/operating_systems? Question 2: Do you know how to hide an endpoint in this swagger version?

Checklist

[X] You added tests to cover the change
[X] mvn clean install build and test completes
[X] You changed or added to the documentation

tellison commented 5 months ago

Question: Do we use /available/operating-systems or /available/operating_systems?

I realise this has already been merged with operating-systems, but given we use underscore everywhere else (feature_version, heap_size, release_type, c_lib, image_type, etc. etc) I'm genuinely surprised why this is committed with a departure from the convention?

"Operating systems" is two words in English, so should be operating_systems in the API. Can we change before too late?

xavierfacq commented 5 months ago

Question: Do we use /available/operating-systems or /available/operating_systems?

I realise this has already been merged with operating-systems, but given we use underscore everywhere else (feature_version, heap_size, release_type, c_lib, image_type, etc. etc) I'm genuinely surprised why this is committed with a departure from the convention?

"Operating systems" is two words in English, so should be operating_systems in the API. Can we change before too late?

I agree with you, I'll push a new PR with that modification

xavierfacq commented 5 months ago

Question: Do we use /available/operating-systems or /available/operating_systems?

I realise this has already been merged with operating-systems, but given we use underscore everywhere else (feature_version, heap_size, release_type, c_lib, image_type, etc. etc) I'm genuinely surprised why this is committed with a departure from the convention?

"Operating systems" is two words in English, so should be operating_systems in the API. Can we change before too late?

Here is the PR for the change : https://github.com/adoptium/api.adoptium.net/pull/1020