adoptium / api.adoptium.net

Adoptium API 🚀
https://api.adoptium.net
Apache License 2.0
32 stars 26 forks source link

Temurin 23 binary builds not accessible through API #840

Open zakkak opened 6 months ago

zakkak commented 6 months ago

Describe the bug Looking at https://github.com/adoptium/temurin23-binaries/releases/ I see jdk-23+2-ea-beta being present, however when trying to get it using:

wget https://api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse

I get a 404 error.

To Reproduce

$ wget https://api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse

--2023-12-20 11:40:34--  https://api.adoptium.net/v3/binary/latest/23/ea/linux/x64/jdk/hotspot/normal/eclipse
Resolving api.adoptium.net (api.adoptium.net)... 20.62.244.126
Connecting to api.adoptium.net (api.adoptium.net)|20.62.244.126|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-12-20 11:40:35 ERROR 404: Not Found.

Expected behavior Get an EA build of JDK 23.

Device (please complete the following information):

Additional context

Last time we faced this issue with JDK 22 it was a matter of redeploying the API endpoint with -DLATEST_JAVA_VERSION=22.

cc @johnoliver @jerboaa

jerboaa commented 6 months ago

Last time we faced this issue with JDK 22 it was a matter of redeploying the API endpoint with -DLATEST_JAVA_VERSION=22

Yes. Probably needs a re-deploy with -DLATEST_JAVA_VERSION=23. /cc @sxa

sxa commented 6 months ago

FYI @andrew-m-leonard

andrew-m-leonard commented 6 months ago

@sxa @jerboaa @johnoliver I seem to remember the API does not currently support returning "tip" version assets, as I remember handling that condition on the daily Slack status code: https://github.com/adoptium/ci-jenkins-pipelines/blob/cb030764501de888c05ebbf6ac1a030731a3e72a/tools/nightly_build_and_test_stats.groovy#L245

jerboaa commented 6 months ago

I'm not sure that's true. See the comments in #720 where we faced this last time. A redeploy of the API endpoint server with -DLATEST_JAVA_VERSION=23 should do the trick. At least it did it last time.

johnoliver commented 6 months ago

should be there now

sxa commented 5 months ago

@johnoliver Can you clarify what was done to fix this? We should have this documented as part of https://github.com/adoptium/temurin-build/wiki/Setting-up-new-build-jobs,-mirrors,...-when-a-new-openjdk-version-is-branched-from-jdk(head)

jerboaa commented 6 days ago

@johnoliver Looks like we need the same fix for JDK 24 now. See #1077.

andrew-m-leonard commented 6 days ago

@johnoliver Is there a way we can make this code dynamic? https://github.com/adoptium/api.adoptium.net/blob/9b536a207a01db1e8d3be0585504391bf439d03a/adoptium-models-parent/adoptium-api-v3-models/src/main/kotlin/net/adoptium/api/v3/models/Versions.kt#L5

eg.