Update JCK Natives compile flags to define _AMD64_ on Windows

adoptium / aqa-systemtest

Java load testing and other full system application tests

Apache License 2.0

19 stars 65 forks source link

Update JCK Natives compile flags to define _AMD64_ on Windows #445

Closed sxa closed 3 years ago

sxa commented 3 years ago

Fixes an issue building the TCK material

Signed-off-by: Stewart X Addison sxa@redhat.com

lumpfish commented 3 years ago

So just to be clear - _AMD64_ needs to be defined for building both 32 bit and 64 bit natives?

sxa commented 3 years ago

So just to be clear - _AMD64_ needs to be defined for both 32 bit and 64 bit natives?

That's likely a question for @d3r3kk specifically, but it seems reasonable if it's an architecture definition and I would be extremely surprised if it caused a problem on 64-bit (it's definitely REQUIRED for 32-bit per the slack thread)

sxa commented 3 years ago

(To be clear on my previous statement I have tested the COMPILATION in a 64-bit setup with that extra /D parameter and it still builds the dll correctly, but I haven't run any tests against it)