adoptium / aqa-systemtest

Java load testing and other full system application tests
Apache License 2.0
19 stars 65 forks source link

Disable ForkJoinTaskTest failed at both OpenJ9 & RI #456

Closed JasonFengJ9 closed 3 years ago

JasonFengJ9 commented 3 years ago

Disable ForkJoinTaskTest failed at both OpenJ9 & RI [1]

To be enabled after fixing OpenJDK.

Note: Attempted to only comment out https://github.com/adoptium/aqa-systemtest/blob/09144b01e8025a6ee44cb8ac05a81df30319c403/openjdk.test.concurrent/src/test.concurrent/net/adoptopenjdk/test/concurrent/jsr166y/ForkJoinTaskTest.java#L174 But got another intermittent failure.

12:34:21  LT  testStarted : testAPI(net.adoptopenjdk.test.concurrent.jsr166y.ForkJoinTaskTest)
12:34:21  LT  testFailure: testAPI(net.adoptopenjdk.test.concurrent.jsr166y.ForkJoinTaskTest): 29 : getMySurplusQueuedTaskCount() expected:<0> but was:<-8>
12:34:21  LT  junit.framework.AssertionFailedError: 29 : getMySurplusQueuedTaskCount() expected:<0> but was:<-8>
12:34:21  LT    at junit.framework.Assert.fail(Assert.java:57)
12:34:21  LT    at junit.framework.Assert.failNotEquals(Assert.java:329)
12:34:21  LT    at junit.framework.Assert.assertEquals(Assert.java:78)
12:34:21  LT    at junit.framework.Assert.assertEquals(Assert.java:234)
12:34:21  LT    at junit.framework.TestCase.assertEquals(TestCase.java:401)
12:34:21  LT    at net.adoptopenjdk.test.concurrent.jsr166y.ForkJoinTaskTest.testAPI(ForkJoinTaskTest.java:187)

Hence excluding net.adoptopenjdk.test.concurrent.jsr166y.ForkJoinTaskTest instead.

[1] https://github.com/eclipse-openj9/openj9/issues/12073

Signed-off-by: Jason Feng fengj@ca.ibm.com

JasonFengJ9 commented 3 years ago

@smlambert @llxia Could you please review?

fyi @keithc-ca

keithc-ca commented 3 years ago

To be enabled after fixing OpenJDK.

... or fixing the test. As Jason pointed out, [1] says the result from getSurplusQueuedTaskCount() may be negative.

[1] https://download.java.net/java/early_access/jdk17/docs/api/java.base/java/util/concurrent/ForkJoinTask.html#getSurplusQueuedTaskCount()

JasonFengJ9 commented 3 years ago

... or fixing the test.

Assuming this is an alternative way to enable the test later, not object to excluding it in this PR.

JasonFengJ9 commented 3 years ago

@llxia @smlambert ping