adoptium / aqa-systemtest

Java load testing and other full system application tests
Apache License 2.0
19 stars 65 forks source link

Add synchronization to Person class #471

Closed IBMJimmyk closed 2 years ago

IBMJimmyk commented 2 years ago

A lock on the Person class must now be acquired before incrementing nextSerialNumber. This prevents conflicting updates when multiple threads try to increment it at the same time.

Signed-off-by: jimmyk jimmyk@ca.ibm.com

IBMJimmyk commented 2 years ago

This is a fix to address: https://github.com/eclipse-openj9/openj9/issues/11900

testConstructorReference in TestLambdaMethodReferences in believed to be failing due to a race condition when nextSerialNumber is incremented during the construction of a Person object.

IBMJimmyk commented 2 years ago

I ran grinders to check that the original issue was fixed. I ran 7 grinders of 100 runs each for a total of 700/700 Passes:

job/Grinder/19523/ job/Grinder/19535/ job/Grinder/19560/ job/Grinder/19561/ job/Grinder/19564/ job/Grinder/19574/ job/Grinder/19582/

@Mesbah-Alam Can you take a look at this?