search

adoptium / aqa-test-tools

Home of Test Results Summary Service (TRSS) and PerfNext. These tools are designed to improve our ability to monitor and triage tests at the Adoptium project. The code is generic enough that it is extensible for use by any project that needs to monitor multiple CI servers and aggregate their results.
Apache License 2.0
28 stars 79 forks source link

Pagination not working on testTable #283

Closed OscarQQ closed 4 years ago

OscarQQ commented 4 years ago

Example: https://trss.adoptopenjdk.net/allTestsInfo?buildId=5eec1717bdbc4f6b2bd217da&limit=5&hasChildren=false

change the pagination will not have any effect

OscarQQ commented 4 years ago
Screen Shot 2020-06-19 at 2 34 46 AM
OscarQQ commented 4 years ago

Place needs to change: https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/7626cb2ce409b499dc9f52fabadc07e527881c07/test-result-summary-client/src/Build/TestTable.jsx#L216 We set the page size to be always 50 here, I search pagination across the codebase and find that we also hardcoded page size somewhere else. Shall I change all of the paginations? Or it's fine to keep these. Possible Fix: pagination={{ pageSize: 50 }}
--> pagination= { { defaultPageSize: 50, pageSizeOptions: ['10', '20', '50', '100'], showSizeChanger: true } }

llxia commented 4 years ago

Please feel free to update the code.