search

adoptium / aqa-test-tools

Home of Test Results Summary Service (TRSS) and PerfNext. These tools are designed to improve our ability to monitor and triage tests at the Adoptium project. The code is generic enough that it is extensible for use by any project that needs to monitor multiple CI servers and aggregate their results.
Apache License 2.0
28 stars 81 forks source link

Update jdkDate parser for various java version #360

Open OscarQQ opened 3 years ago

OscarQQ commented 3 years ago

Our current parser looks for yyyymmdd https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/67ae218ec906fb9168bd81a9de87f090d5c2d701/TestResultSummaryService/parsers/Parser.js#L12 while hot spot and corretto has the form yyyy-mm-dd ex. https://ci.adoptopenjdk.net/job/Test_openjdk11_corretto_sanity.perf_x86-64_linux/296/consoleFull

09:43:21  =JAVA VERSION OUTPUT BEGIN=
09:43:21  openjdk version "11.0.11" 2021-04-20
09:43:21  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.11+1)
09:43:21  OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.11+1, mixed mode)
09:43:21  =JAVA VERSION OUTPUT END=
OscarQQ commented 3 years ago

closed by https://github.com/AdoptOpenJDK/openjdk-test-tools/pull/362

OscarQQ commented 3 years ago 
18:42:33  =JAVA VERSION OUTPUT BEGIN=
18:42:33  openjdk version "11.0.11" 2021-04-20
18:42:33  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.11+5-202103050214)
18:42:33  Eclipse OpenJ9 VM AdoptOpenJDK (build master-d780e8d8b, JRE 11 Linux amd64-64-Bit Compressed References 20210305_78 (JIT enabled, AOT enabled)
18:42:33  OpenJ9   - d780e8d8b
18:42:33  OMR      - 19483f8eb
18:42:33  JCL      - 83787478bb based on jdk-11.0.11+5)
18:42:33  =JAVA VERSION OUTPUT END=

TRSS will grab 2021-04-20 as jdkDate while 20210305 makes more sense to me, I am wondering how we come up with a java version in the future..

link: internal_jenkins_server/Test_openjdk11_j9_sanity.perf_x86-64_linux/732/consoleFull

OscarQQ commented 3 years ago

@smlambert A lot of builds have 

openjdk version "11.0.11" 2021-04-20

ex. https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.perf_x86-64_linux/481/consoleFull https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.perf_x86-64_linux/478/ https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.perf_x86-64_linux/477/ where 2021-04-20 hasn't come yet...

OscarQQ commented 3 years ago

hs has java version as

13:09:49  =JAVA VERSION OUTPUT BEGIN=
13:09:49  openjdk version "1.8.0_292-internal"
13:09:49  OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-internal-202103081818-b05)
13:09:49  OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b05, mixed mode)
13:09:49  =JAVA VERSION OUTPUT END=

example link: https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.perf_x86-64_linux/674/consoleFull Our TRSS parser regex is /\s([0-9]{4})-?(0[1-9]|1[012])-?(0[1-9]|[12][0-9]|3[01])/ which will look for a space first, which now it should be a '-'

aahlenst commented 3 years ago

where 2021-04-20 hasn't come yet...

That's the release date. 11.0.11 will come out on that day.

smlambert commented 3 years ago

is this the same as https://github.com/adoptium/aqa-test-tools/issues/449?

llxia commented 3 years ago

I think the PR of this issue caused #449.