Should we specify a limiting max heap size on test jobs to control things like max dump sizes ?

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds

https://adoptium.net/aqavit

Apache License 2.0

129 stars 308 forks source link

Should we specify a limiting max heap size on test jobs to control things like max dump sizes ? #2195

Open andrew-m-leonard opened 3 years ago

andrew-m-leonard commented 3 years ago

Issues have been seen with openj9 AIX testcases that produce dumps that are 30+Gb, because the default heapsize is 25% available RAM, and on some AIX boxes there can be a huge amount of available RAM. But we may only have a 30Gb disk partition.

Should we specify a -Xmx, at least for openj9?

llxia commented 3 years ago

IMHO, each test should be responsible for itself. Having the test pipeline blindly overrides the value may cause various problems.

smlambert commented 3 years ago

Yes, I think we saw that when trying to limit -Xmx during the release... that some tests need different values and we'll see different failures if blanket change is applied.

I think we can better handle the situation this issue is intended to report by a combination of:

tuning the particular functional tests in question (it will be useful to list those as part of the description of this issue)
the MachineInfo work that is now underway in TKG Testing environment checks issue.

andrew-m-leonard commented 3 years ago

Here's a list of the functional tests changed: https://github.com/eclipse/openj9/pull/11340