search

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
132 stars 312 forks source link

Separate test groups into different files based on JDK_VERSION #4455

Open llxia opened 1 year ago

llxia commented 1 year ago

In https://github.com/adoptium/aqa-tests/blob/master/jck/jck.mk, we have test groups per JDK_VERSION. This makes jck.mk very long and hard to review, compare and maintain. For example, PR https://github.com/adoptium/aqa-tests/pull/4454

I would like to suggest separating test groups into different files based on JDK_VERSION. For example, create a testGroup folder. In the testGroup folder, we can have test group file for each version (i.e., jdk8.mk, jdk11.mk, jdk17.mk, etc). These test group make files can be included based on the current JDK_VERSION. Similar to the files in https://github.com/adoptium/aqa-tests/tree/master/openjdk/excludes

@smlambert @Mesbah-Alam what's your recommendation on this? I am open to other suggestions.

Mesbah-Alam commented 1 year ago

It is a good idea. Especially with multijvm versions potentially introducing more broken down targets in near future.