adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
135 stars 314 forks source link

Check build.xml files to ensure they fail fast when one of their targets fail #4701

Open smlambert opened 1 year ago

smlambert commented 1 year ago

This came up in context of JavaTestUtil.java failed to compile, but we continued on to try and run tests. See: https://github.com/adoptium/aqa-tests/blob/master/jck/build.xml

We should check all build.xml files in this repo and add failonerror="true" in targets that need it, much like was done in https://github.com/adoptium/aqa-tests/pull/2179

smlambert commented 1 year ago

Noting that the build-jtrunner target which is how JavaTestUtil is compiled has failonerror="true" set, looking at if it propagated properly.

beRajeevKumar commented 1 year ago

Dear @smlambert,

I would like to request that you kindly assign this issue to me. As a beginner open-source contributor, I am eager to take on the challenge and work towards fixing it. Your support and guidance would be greatly appreciated.

Thank you in advance.

Best regards, Rajeev Kumar