search

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
129 stars 308 forks source link

Verify and reenable testcases related to Backport for JDK-8311964: x86 bug 'unrecognized VM options' (C2 flags) #5011

Open adamfarley opened 7 months ago

adamfarley commented 7 months ago

Summary

An upstream bug has been seen in JDK21 (and under) testing at Adoptium.

To solve this, we should request that the fix for that bug be backported.

Details

Adoptium test failures were documented here and here.

These tests were subsequently excluded here.

These failures look like they were caused by this OpenJDK bug.

We see that this bug has been fixed, and that the fix was merged into JDK22+.

To solve this problem at Adoptium, a backport was proposed in the General Retrospective for the Adoptium January 2024 releases.

adamfarley commented 7 months ago

Thanks Shelley :)

jiekang commented 6 months ago

Backport has been made to 21u and 17u by sendaoYan in February, see issue comments in link below:

https://bugs.openjdk.org/browse/JDK-8311964

smlambert commented 6 months ago

Changing the title to reflect the action now is to check that the test cases can be re-included. related: https://github.com/adoptium/aqa-tests/pull/4965

jiekang commented 6 months ago

Noting for future investigator, the OpenJDK PR only mentions three tests:

Following tests were affected:
TestInfiniteLoopWithUnmergedBackedgesMain.java - Affected by 'LoopUnswitching'
TestBackedgeLoadArrayFillMain.java - Affected by 'OptimizeFill'
TestRangeCheckCmpUOverflowVsSub.java - Affected by 'StressCCP'
jiekang commented 6 months ago

Also just further checked, the PRs to backport have been opened but not approved or merged. Sorry.

https://github.com/openjdk/jdk21u-dev/pull/279 https://github.com/openjdk/jdk17u-dev/pull/2216

sendaoYan commented 6 months ago

Also just further checked, the PRs to backport have been opened but not approved or merged. Sorry.

openjdk/jdk21u-dev#279 openjdk/jdk17u-dev#2216

I will try to backport there two PRs as soon as quick possible.

jiekang commented 6 months ago

@sendaoYan

Ah, thank you for the update. And thanks for doing the work to backport those changes!

I did not mean to suggest they need to be done immediately. When you have time to do them is great!

sendaoYan commented 6 months ago

@sendaoYan

Ah, thank you for the update. And thanks for doing the work to backport those changes!

I did not mean to suggest they need to be done immediately. When you have time to do them is great!

OK.