adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
132 stars 312 forks source link

Reduce duplication of test data in MBCS test suite #5161

Open smlambert opened 7 months ago

smlambert commented 7 months ago

Currently the MBCS test suite pulls in test data from unicode.org public data, to be able to compare what the JDK produces, versus what is expected based on the test data.

For expediency, a copy of this test data is in the MBCS_Tests directory. In fact, certain files are duplicate within subdirectories like https://github.com/adoptium/aqa-tests/blob/master/functional/MBCS_Tests/codepoint/data/UnicodeData-15.1.0.txt and https://github.com/adoptium/aqa-tests/blob/master/functional/MBCS_Tests/unicode/data/UnicodeData-15.1.0.txt.

We can improve this in 2 ways:

Noting that in a recent update to the MBCS suite https://github.com/adoptium/aqa-tests/pull/5150, 9 of 13 files were test data, while the 4 src files changed only required 10 lines of code changed. Managing the test data differently would reduce maintenance costs of this suite.

smlambert commented 6 months ago

Items to move out of aqa-tests and pulled in as testDependency

Items to consider **/data/* in other subdirs, though they do not appear to be duplicating content