search

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
132 stars 312 forks source link

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net #5286

Open llxia opened 5 months ago

llxia commented 5 months ago

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net Jenkins. We should change it based on the Jenkins domain: https://github.com/adoptium/aqa-tests/blob/9639787ceb52518750af88b8d611a7276e4742bb/buildenv/jenkins/JenkinsfileBase#L210

We can leverage the following for Jenkins domain value: https://github.com/adoptium/aqa-tests/blob/9639787ceb52518750af88b8d611a7276e4742bb/buildenv/jenkins/JenkinsfileBase#L1046

This allows each vendor to adjust test.getDependency job if needed.

related: https://github.com/adoptium/aqa-tests/issues/5283#issuecomment-2098668955

llxia commented 5 months ago

@annaibm please take a look. Thanks

llxia commented 5 months ago

@annaibm I just remembered that we would not be able to access the Jenkins URL if anonymous access is not allowed. This was one of the reasons that we set Adoptium jenkins URL in the first place. Please add the check:

if JenkinsDomain contains `hyc-runtimes`
   use openj9 Jenkins
else
    use JenkinsDomain