adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
130 stars 308 forks source link

openjdk: langtools_all target #5353

Closed zzambers closed 4 months ago

zzambers commented 4 months ago

This adds langtools_all target to openjdk to run langtools tests (see: https://github.com/adoptium/aqa-tests/issues/5318).

Testing: x86-64_linux: jdk 21: OK jdk 17: OK jdk 11: OK jdk 8: OK

x86-64_windows jdk 21: OK jdk 8: FAILED (infra issue?, rerun OK)

x86-64_mac jdk 21: OK jdk 8: OK

llxia commented 4 months ago

I do not think langtools is fully enabled in openj9/ibm. Please run the Grinder to ensure this test is valid for openj9.

sophia-guo commented 4 months ago

@llxia could you please point the openj9/ibm SDK URL ?

zzambers commented 4 months ago

I have tried openj9 using example urls as CUSTOMIZED_SDK_URL. I see some failures:

x86-64_linux / jdk8 / openj9: FAILURES ppc64le_linux / jdk17 / openj9: FAILURES

this is interesting, I would not expect that using different jvm, should make difference here (javac, javadoc), but obviously it does.

zzambers commented 4 months ago

I can make langtools_all hotspot only for now.

llxia commented 4 months ago

@pshipton could you please confirm that we should exclude langtools tests for openj9/ibm? If so, do we have an openj9 issue for reference in the disabled comment? Thanks

pshipton commented 4 months ago

Created https://github.com/eclipse-openj9/openj9/issues/19605

llxia commented 4 months ago

@zzambers please disable langtools_all target for both impl openj9 and ibm and reference https://github.com/eclipse-openj9/openj9/issues/19605 in the disable comment. Thanks

zzambers commented 4 months ago

@llxia thanks

btw. I have tried to rerun openj9 jobs, verified, that openj9 failures are reproducible in grinder: https://ci.adoptium.net/view/Test_grinder/job/Grinder/10149/ https://ci.adoptium.net/view/Test_grinder/job/Grinder/10150/