Update MockitoTest's build.xml to use the same jdk version as to playlist.xml

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds

https://adoptium.net/aqavit

Apache License 2.0

125 stars 304 forks source link

Update MockitoTest's build.xml to use the same jdk version as to playlist.xml #5359

Closed sophiaxu0424 closed 1 month ago

sophiaxu0424 commented 1 month ago

Issue to https://github.com/adoptium/infrastructure/issues/3043

sophiaxu0424 commented 1 month ago

Running with nightly jdk11, and it passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/40988/console

~Still need to dive into the case with jdk8 for fixing the 55.0 version error in build.xml~

sophiaxu0424 commented 1 month ago

Trying to testing on jdk8, but both failed with origin master branch, and this PR branch, expected SKIPPED, but keeps failing. Testing with origin master branch, nightly jdk8 https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41000/ failed with compile error

Testing with this PR issue3043 branch, nightly jdk8 https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41001/ failed with compile error

sophiaxu0424 commented 1 month ago

@llxia @LongyuZhang Would you please kindly check and see if other test should be prepared? TIA!

sophiaxu0424 commented 1 month ago

Since this PR is to fix JDK8 build failure, the grinder test needs to run with JDK8 other tests (reproduce what caused failure in the origin issue) to prove this change fixed it.

Hi Longyu,

The original mockito test case with jdk11+ limitations, has compile failure and can't be skipped. while when we remove the jdk11+ limitation, the reported issue class file has wrong version 55.0, should be 52.0 could be reproduced, and this reported issue came from the mockito (third-party) not our side, and we are waiting for them to fix.

I am wondering that maybe we should add this jdk8 to disabled list to avoid this compile failure? please advice as well. thanks!

LongyuZhang commented 1 month ago

@sophiaxu0424 To validate this changes fixed the JDK8 problem, you can run your branch in a grinder with

DYNAMIC_COMPILE set to unchecked;
JDK is JDK 8
Target is floatSanityTests Then make sure this grinder passed, and the console contains info of either MockitoTest skipped or not shown at all. Thanks.

sophiaxu0424 commented 1 month ago

Thanks Longyu, the required floatSanityTests on jdk8 has passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41093/