Support openj9 to run openjdk hotspot_custom target for jvmti tests

LongyuZhang commented 4 weeks ago

Leveraging hotspot_custom to support openj9 to run openjdk custom target
Related Issue: https://github.com/adoptium/aqa-tests/issues/5357

LongyuZhang commented 4 weeks ago

Test Link: hyc_grinder 41198

TARGET: disabled.hotspot_custom,

CUSTOM_TARGET: serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java

14:55:09  TEST: serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java
14:55:09  TEST JDK: /home/jenkins/workspace/Grinder/jdkbinary/j2sdk-image

However, this test failed with output:

14:55:09  ACTION: main -- Failed. Unexpected exit from test [exit code: 1]
14:55:09  REASON: User specified action: run main/othervm/native -agentlib:JvmtiGetSystemPropertyTest JvmtiGetSystemPropertyTest 
14:55:09  TIME:   0.105 seconds
14:55:09  messages:
14:55:09  command: main -agentlib:JvmtiGetSystemPropertyTest JvmtiGetSystemPropertyTest
14:55:09  reason: User specified action: run main/othervm/native -agentlib:JvmtiGetSystemPropertyTest JvmtiGetSystemPropertyTest 
14:55:09  started: Wed Jun 05 11:55:09 PDT 2024
14:55:09  Mode: othervm [/othervm specified]
14:55:09  finished: Wed Jun 05 11:55:09 PDT 2024
14:55:09  elapsed time (seconds): 0.105
14:55:09  configuration:
14:55:09  STDOUT:
14:55:09  STDERR:
14:55:09  JVMJ9TI001E Agent library JvmtiGetSystemPropertyTest could not be opened (libJvmtiGetSystemPropertyTest.so: cannot open shared object file: No such file or directory)
14:55:09  JVMJ9VM015W Initialization error for library j9jvmti29(-3): JVMJ9VM009E J9VMDllMain failed

@fengxue-IS would you have any suggestion about this failure? Thanks.

pshipton commented 4 weeks ago

libJvmtiGetSystemPropertyTest.so should be part of the test image, but it's not on jdk17. I see it's there for jdk21. Seems we need to expand building the native code for jdk17 similarly to what has been done for jdk21.

fengxue-IS commented 4 weeks ago

serviceability test suite have only been enabled on OpenJ9 for JDK 19+ to support Project Loom, so I don't suppose this should be verified against JDK17

LongyuZhang commented 4 weeks ago

Tested with JDK21 (hyc_grinder 41212), still failed with the same output: TARGET: disabled.hotspot_custom, CUSTOM_TARGET: serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java

21:48:14  STDERR:
21:48:14  JVMJ9TI001E Agent library JvmtiGetSystemPropertyTest could not be opened (libJvmtiGetSystemPropertyTest.so: cannot open shared object file: No such file or directory)
21:48:14  JVMJ9VM015W Initialization error for library j9jvmti29(-3): JVMJ9VM009E J9VMDllMain failed

LongyuZhang commented 4 weeks ago

Test with sanity/BasicVMTest.java, passed successfully (hyc_grinder 41215/testReport)

TARGET: disabled.hotspot_custom
CUSTOM_TARGET: sanity/BasicVMTest.java

fengxue-IS commented 4 weeks ago

Tested with JDK21 (hyc_grinder 41212), still failed with the same output: TARGET: disabled.hotspot_custom, CUSTOM_TARGET: serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java
21:48:14  STDERR:
21:48:14  JVMJ9TI001E Agent library JvmtiGetSystemPropertyTest could not be opened (libJvmtiGetSystemPropertyTest.so: cannot open shared object file: No such file or directory)
21:48:14  JVMJ9VM015W Initialization error for library j9jvmti29(-3): JVMJ9VM009E J9VMDllMain failed

I suspect the failure is due to use of JVM_NATIVE_OPTIONS in https://github.com/adoptium/aqa-tests/blob/0f1508971ddb416332fdf96de93fd9c1a9f4dfc3/openjdk/playlist.xml#L105

which is defined based on the JDK_IMPL test is running against: https://github.com/adoptium/aqa-tests/blob/0f1508971ddb416332fdf96de93fd9c1a9f4dfc3/openjdk/openjdk.mk#L184-L190

but for serviceability test suite, -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native" is required for openj9 impl as well. see example in serviceability_jvmti_j9 suite https://github.com/adoptium/aqa-tests/blob/0f1508971ddb416332fdf96de93fd9c1a9f4dfc3/openjdk/playlist.xml#L401-L408

FYI @LongyuZhang

llxia commented 3 weeks ago

I thought I commented on it yesterday. Anyway, instead of using JVM_NATIVE_OPTIONS in the playlist for hotspot_custom, set -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native"

Subtests of serviceability_jvmti_j9 (i.e., serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java) have to run to completion with hotspot_custom. It is the purpose of this PR.

LongyuZhang commented 3 weeks ago

Updated the PR based on @fengxue-IS and @llxia comments. New test links for serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java

Openj9 (TARGET: disabled.hotspot_custom): hyc_grinder 41254/testReport
Hotspot (TARGET: hotspot_custom): https://ci.adoptium.net/view/Test_grinder/job/Grinder/10272/testReport/

adoptium / aqa-tests

Support openj9 to run openjdk hotspot_custom target for jvmti tests #5370