adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
130 stars 308 forks source link

Investigate what updates are needed to support new upstream jdk release branching model #5391

Closed smlambert closed 3 months ago

smlambert commented 3 months ago

Described in https://github.com/adoptium/temurin-build/issues/3841 the upstream jdk repositories now have a different branching scheme. We need to investigate what is needed to support this in aqa-tests code/scripts.

Files that will likely need updates:

Any others?

Actually the caller code in ci-jenkins-pipeline repo that needs updates, as the logic is to give the test pipeline code a repo and branch name (JDK_REPO, JDK_BRANCH) and we will pull from what is passed in to us.

Related: getJdkRepo: https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L292-L295

getJdkBranch: https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L206-L237

set test job params based on values pulled from getJdkRepo and getJdkBranch: https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L466-L467

smlambert commented 3 months ago

jdk23 test job failures for openjdk group of tests:

15:37:15  getOpenjdk:
15:37:15       [echo] Using user specified repo and branch
15:37:15       [exec] info: Could not add alternate for '/home/jenkins/openjdk_cache': reference repository '/home/jenkins/openjdk_cache' is not a local repository.git clone --depth 1 -q --reference-if-able /home/jenkins/openjdk_cache -b jdk-23+28_adopt https://github.com/adoptium/jdk23 openjdktemp
15:37:15       [exec] 
15:37:15       [exec] error code: 128. Sleep 300 secs, then retry 1...
15:37:15       [exec] fatal: could not read Username for 'https://github.com/': No such device or address
15:42:26       [exec] check for openjdktemp. If found, the file will be removed.
15:42:26       [exec] git clone --depth 1 -q --reference-if-able /home/jenkins/openjdk_cache -b jdk-23+28_adopt https://github.com/adoptium/jdk23 openjdktemp
15:42:26       [exec] info: Could not add alternate for '/home/jenkins/openjdk_cache': reference repository '/home/jenkins/openjdk_cache' is not a local repository.
15:42:26       [exec] error code: 128. Sleep 300 secs, then retry 2...
15:42:26       [exec] fatal: could not read Username for 'https://github.com/': No such device or address
15:47:20       [exec] check for openjdktemp. If found, the file will be removed.
15:47:20       [exec] git clone --depth 1 -q --reference-if-able /home/jenkins/openjdk_cache -b jdk-23+28_adopt https://github.com/adoptium/jdk23 openjdktemp
15:47:20       [exec] info: Could not add alternate for '/home/jenkins/openjdk_cache': reference repository '/home/jenkins/openjdk_cache' is not a local repository.
15:47:20       [exec] error code: 128. Sleep 300 secs, then retry 3...
15:47:20       [exec] fatal: could not read Username for 'https://github.com/': No such device or address
15:52:16       [exec] check for openjdktemp. If found, the file will be removed.
15:52:16       [exec] git clone --depth 1 -q --reference-if-able /home/jenkins/openjdk_cache -b jdk-23+28_adopt https://github.com/adoptium/jdk23 openjdktemp
15:52:16       [exec] info: Could not add alternate for '/home/jenkins/openjdk_cache': reference repository '/home/jenkins/openjdk_cache' is not a local repository.
15:52:16       [exec] error code: 128. Sleep 300 secs, then retry 4...
15:52:16       [exec] fatal: could not read Username for 'https://github.com/': No such device or address
15:57:26       [exec] info: Could not add alternate for '/home/jenkins/openjdk_cache': reference repository '/home/jenkins/openjdk_cache' is not a local repository.
15:57:26       [exec] check for openjdktemp. If found, the file will be removed.
15:57:26       [exec] git clone --depth 1 -q --reference-if-able /home/jenkins/openjdk_cache -b jdk-23+28_adopt https://github.com/adoptium/jdk23 openjdktemp
15:57:26       [exec] error code: 128. Sleep 300 secs, then retry 5...
15:57:26       [exec] fatal: could not read Username for 'https://github.com/': No such device or address
16:02:21       [exec] check for openjdktemp. If found, the file will be removed.
16:02:21       [exec] git clone --depth 1 -q --reference-if-able /home/jenkins/openjdk_cache -b jdk-23+28_adopt https://github.com/adoptium/jdk23 openjdktemp
16:02:21       [exec] info: Could not add alternate for '/home/jenkins/openjdk_cache': reference repository '/home/jenkins/openjdk_cache' is not a local repository.
16:02:21       [exec] fatal: could not read Username for 'https://github.com/': No such device or address

For jdk23+, branching off of https://github.com/adoptium/jdk, so instead of a separate mirror called https://github.com/adoptium/jdk23 or https://github.com/adoptium/jdk23u, we should pull material from a branch called jdk23 of the jdk repo, see: https://github.com/adoptium/jdk/tree/jdk23.

smlambert commented 3 months ago

This issue is addressed by https://github.com/adoptium/ci-jenkins-pipelines/pull/1053