search

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
125 stars 304 forks source link

Exclude 2 ipv6 jdk8 tests on linux-all for Adoptium #5402

Closed Haroon-Khel closed 6 days ago

Haroon-Khel commented 1 week ago

Both tests are failing consistently on JDK8 linux platforms, https://github.com/adoptium/infrastructure/issues/3614.

Haroon-Khel commented 6 days ago

Approving as we had done this for mac, but this is quite specific to our Adoptium infrastructure not having IPv6 enabled, so perhaps we should have these excludes in a vendor/adoptium excludes folder, instead of excluding testcases for all vendors.

I didn't realise that was an option, that's a better idea. I've changed the pr accordingly

Haroon-Khel commented 6 days ago

I dont have write access so I can't merge this despite the 2 approvals

sophia-guo commented 6 days ago

@Haroon-Khel I didn't realize that you have updated to vendor/adoptium folder and merged. I don't think currently we support adoptium vendor yet

sophia-guo commented 6 days ago

Checked TKG, for now If System.getProperty('java.vendor')=Eclipse Adoptium jdk_vendor is set as eclipse. Could we use /vendor/eclipse @smlambert ? If yes @Haroon-Khel we need to update https://github.com/adoptium/aqa-tests/blob/master/openjdk/openjdk.mk#L238 to include eclipse