adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
127 stars 306 forks source link

JDK8: External.sanity: Docker file fails to build due to FUNCTIONAL_TEST_TAG error #5422

Open adamfarley opened 2 weeks ago

adamfarley commented 2 weeks ago

Summary Sanity.external docker file appears to require a syntax fix.

Error message

21:30:56       [exec] Step 22/27 : RUN git checkout FUNCTIONAL_TEST_TAG
21:30:56       [exec]  ---> Running in 173e36e3275e
21:30:57       [exec] error: pathspec 'FUNCTIONAL_TEST_TAG' did not match any file(s) known to git
21:30:57       [exec] The command '/bin/sh -c git checkout FUNCTIONAL_TEST_TAG' returned a non-zero code: 1
21:30:57       [exec] 

URL https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.external_x86-64_linux_testList_0/1/console

Next steps This should be assigned to the POC for external testing so they can fix it. Will add a comment in Slack.

smlambert commented 2 weeks ago

@LongyuZhang - are you running with an additional parameter being set that we are not using in our EA-triggered pipelines on ci.adoptium.net, or is FUNCTIONAL_TEST_TAG supposed to be set from testenv.properties file (even if we are not setting USE_TESTENV_PROPERTIES=true ?

LongyuZhang commented 2 weeks ago

It seems to be related to branch setting through sanitize_test_names to set the tag (link), will look into it.

LongyuZhang commented 2 weeks ago

The ADOPTOPENJDK_SHA used in this test is 7e3811b9d4c6fcf265d2fc7e9852412034fe6260 which is two weeks ago. The tag problem has been fixed by PR later than it https://github.com/adoptium/aqa-tests/pull/5406.

smlambert commented 2 weeks ago

tag problem has been fixed by PR later than it https://github.com/adoptium/aqa-tests/pull/5406

Thanks for the answer Longyu!