search

adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
132 stars 312 forks source link

Fix external container-based tests JDK_VERSION setting #5449

Open sophiaxu0424 opened 3 months ago

sophiaxu0424 commented 3 months ago

Related to issue: https://github.com/adoptium/aqa-tests/issues/5315

Following the steps to verify the mismatch and fix

sophiaxu0424 commented 2 months ago

Grinder Tests: all passed for related testcases

external/functional-test/example_functional https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42443 passed external/criu-functional https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42459/ passed external/criu-portable-checkpoint_test https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42461 passed external/criu-ubi-portable-checkpoint_test https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42462/ passed

sophiaxu0424 commented 2 months ago

Hi @LongyuZhang @llxia would you please kind review, thanks!

sophiaxu0424 commented 2 months ago

Only run this target external/functional-test/example_functiona: Passed Grinder test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42544/

sophiaxu0424 commented 2 months ago

After talk with Longyu, we decide not to include this change into master for now, as this change might cause break of other external tests related to this external_custom target,etc. Also waiting for a reply from shelley from this issue: https://github.com/adoptium/aqa-tests/issues/5462#issuecomment-2259032339 Transfer to Draft for now.