adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
131 stars 314 forks source link

Tag jar/war files as binary encodings #5534

Open psoujany opened 2 months ago

psoujany commented 2 months ago

Files here needs to be tagged as binary due to JDK21 changes on z/OS. https://github.com/adoptium/aqa-tests/tree/master/functional/MBCS_Tests/jdbc41/derby/db-derby-10.14.2.0-lib/lib

We also need below commit to be reverted as JDK21 latest builds have fixes for JEP400 https://github.com/adoptium/TKG/commit/28c7f761d9d2e60043930c1d699ad79c72c2a29c

smlambert commented 2 months ago

Please see these 2 other issues, https://github.com/adoptium/aqa-tests/issues/5161 and https://github.com/adoptium/aqa-tests/issues/5148.

We would ultimately like to clean up the MBCS_Tests dir to move out any binaries and test data (move them out as dependencies, not keep them in the aqa-tests repo).

psoujany commented 2 months ago

Thank you @smlambert. Do we have any outlook for this movement? Currently JDK21 z/OS testing is failing due to this improper tagging, we've been using developer branch for our testing as a workaround.

smlambert commented 2 months ago

I was hoping you'd volunteer to do the work :)

psoujany commented 2 months ago

Sure I'll pick up. Thank you.