adoptium / aqa-tests

Home of test infrastructure for Adoptium builds
https://adoptium.net/aqavit
Apache License 2.0
129 stars 308 forks source link

add logic for jdk-version specific suites #5575

Open judovana opened 1 week ago

judovana commented 1 week ago

https://github.com/adoptium/aqa-tests/pull/5553#issuecomment-2340815163 have reminded me old issue, where some external tests, eg jacoco, works fine with 8-17 but do not work with jdk21

Unluckily, current logic to clone and checkout is in https://github.com/adoptium/aqa-tests/blob/master/external/jacoco/test.properties

So I see several options with many pros and cons:

This will be quite a precedent for other - at least external - tests

Many others maybe have to be simply disabled for older/newer jdks, but that is easily done in playlists?

smlambert commented 1 week ago

Thanks for raising this issue @judovana. Before any option is chosen, it will be good to create a table of external apps, their versions and which ones work with which Java version. That will be useful to visualize and help inform the best way forward.

judovana commented 1 week ago

Thanks for raising this issue @judovana. Before any option is chosen, it will be good to create a table of external apps, their versions and which ones work with which Java version. That will be useful to visualize and help inform the best way forward.

thats terrible task.... I would much rather go one by one:(

judovana commented 1 week ago

But yah, would try to do that. You are rigth that it is moreover necessary

smlambert commented 1 week ago

But yah, would try to do that. You are rigth that it is moreover necessary

We can work on it together :)

judovana commented 1 week ago

I will wait for https://github.com/adoptium/aqa-tests/pull/5553 to merge. Once I will be doing such a matrix, I will include multi-base-images to it.