adoptium / bumblebench

A microbenchmarking test framework for Eclipse Adoptium
Apache License 2.0
23 stars 32 forks source link

Add benchmark for String.indexOf(String) #10

Closed NigelYiboYu closed 4 years ago

NigelYiboYu commented 6 years ago

Add benchmark for String.indexOf(String) API

Signed-off-by: Nigel Yu yunigel@ca.ibm.com

NigelYiboYu commented 6 years ago

Updated the benchmark to use a human-readable string as its default source string, based on which sub-strings are generated. This 64K character long source string is preprocessed to contain only compressible characters.

fjeremic commented 4 years ago

@piyush286 / @smlambert do you might know how typically gets assigned to be a committer for these PRs? It would still be valuable to have them merged.

piyush286 commented 4 years ago

I usually request a review from @smlambert, who can throw more light on this.

smlambert commented 4 years ago

Did not see this as active, so it fell off my radar, apologies.

I can review, and would merge once I run a Grinder (assuming it will get exercised as part of this target: https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/perf/bumbleBench/playlist.xml#L539).

piyush286 commented 4 years ago

This is a new test case StringIndexOfStringBench so we'll need to add it to our BumbleBench playlist file. I can add it and test this change once we're done with Quarkus testing, unless someone else gets to it before that.

The above test case is for StringIndexOfBench: https://github.com/AdoptOpenJDK/bumblebench/blob/master/net/adoptopenjdk/bumblebench/string/StringIndexOfBench.java https://github.com/AdoptOpenJDK/openjdk-tests/blob/dc1569c25d402cd3c4936f95ed49bcf5786b1ef9/perf/bumbleBench/playlist.xml#L540

smlambert commented 4 years ago

Run locally, we can/should create a new test target for it next week.

fjeremic commented 4 years ago

Thanks everyone!