search

adoptium / bumblebench

A microbenchmarking test framework for Eclipse Adoptium
Apache License 2.0
23 stars 32 forks source link

Build error on jdk8 tests #36

Closed sxa closed 2 months ago

sxa commented 2 months ago

Found at https://github.com/adoptium/infrastructure/issues/3718 - log excerpt is in that issue Likely caused by https://github.com/adoptium/bumblebench/pull/35 where the failing lines were added. Possible jdk8u specific issue with a construct that was added in later JDKs? Noting that job 666 was a re-run of the last successful build and also failed, therefore it is unrelated to the "special" build referenced in the infrastructure issue where this was seen. FYI @dylanjtuttle

dylanjtuttle commented 2 months ago

Whoops, sorry! Looks like String.repeat is a JDK 11+ feature. I could use a for loop to do the repeating manually, would that be acceptable?

sxa commented 2 months ago

Whoops, sorry! Looks like String.repeat is a JDK 11+ feature. I could use a for loop to do the repeating manually, would that be acceptable?

Sounds good to me if it lets the job run cleanly ;-)