search

adoptium / ci-jenkins-pipelines

jenkins pipeline build scripts
Apache License 2.0
19 stars 71 forks source link

Update archive filename for reproducible comparison job #1073

Closed jiekang closed 4 months ago

jiekang commented 4 months ago

Fixes #1072

github-actions[bot] commented 4 months ago

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR. If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here. To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

jiekang commented 4 months ago

See also: https://github.com/adoptium/temurin-build/pull/3877

jiekang commented 4 months ago

Semgrep failure needs an update to https://github.com/adoptium/ci-jenkins-pipelines/blob/b908532b05a3495bedafe27a736b0b9e4e650414/.github/workflows/semgrep_diff.yml

similar to https://github.com/adoptium/temurin-build/commit/aabf7a548c924d12501930df89ee907371d237e0

jiekang commented 4 months ago

Semgrep fix now available here: https://github.com/adoptium/ci-jenkins-pipelines/pull/1075