search

adoptium / ci-jenkins-pipelines

jenkins pipeline build scripts
Apache License 2.0
19 stars 70 forks source link

Remove use of --user-openjdk-build-root-directory now JDK-8326685 backported #1084

Closed andrew-m-leonard closed 2 months ago

andrew-m-leonard commented 2 months ago

JDK-8326685 provides an official fix for the Linux debug map reproducible build issue, this is now backported to jdk-21.0.4, and the workaround to use a user build folder is not required. The workaround was incorrectly applied to Windows, which then caused a subsequent non-reproducible issue due to relative path building not being used.

Fixes https://github.com/adoptium/temurin-build/issues/3790

github-actions[bot] commented 2 months ago

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR. If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here. To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

andrew-m-leonard commented 2 months ago

run tests

eclipse-temurin-bot commented 2 months ago

 PR TESTER RESULT 

✅ All pipelines passed! ✅

andrew-m-leonard commented 2 months ago

Noting that the logic being removed was originally added in https://github.com/adoptium/ci-jenkins-pipelines/pull/998/files I presume this is not a Windows-specific change given that JDK-8326685 appears to only mention Linux?

Also, is it still possible to reproduce the latest JDk21/22 releases on Windows if this change isn't included (i.e. with the options included in the July SBOMs)?

It was introduced in this PR https://github.com/adoptium/ci-jenkins-pipelines/commit/e297546378b5fbdb676223eb1ae2a0abe7406679 the one you refer to was a builds break fix. Yes, it should never have been used for Windows

Yes, reproducing July Windows using the release jobs and July v2024.07.01 branch will work fine.