NODE_LABEL should be more configurable

M-Davies commented 3 years ago

🆕🐥🐶 First Timers Only

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

👾 Description of the issue For the AdoptOpenJDK build we need some better configuration options for variables. Internally Groovy is used to executer parts of the CI build of AdoptOpenJDK. These parts of the build should be configurable. Today some variables are still hard coded. This issue should refactor two of these parts:

This line of Groovy code contains 2 problems:

[ ] "${additionalNodeLabels}&&${platformConfig.os}&&${platformConfig.arch}" label is hardcoded and could be parameterized via our config files (see https://github.com/AdoptOpenJDK/openjdk-build/pull/2100 for an example of this being done for Docker node labels). Specifically, the && parts of the string are preventing users from making their own node strings without &&. We should have an additional configuration value (CUSTOM_NODE_LABEL?) that specifies a user provided node string.

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[x] Claim this issue: Comment below.
[ ] Fork the repository in github by simply clicking the 'fork' button.
[ ] Check out the forked repository
[ ] Create a feature branch for the issue. We do not have any naming definition for branches.
[ ] Commit your changes.
[ ] Start a Pull Request.
[ ] Done 👍 Ask in comments for a review :)
[ ] If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ] You did it 🎉 We will merge the fix in the master branch.
[ ] Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽

🤔❓ Questions

If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Antonynans commented 3 years ago

Hi can I be assigned this issue

M-Davies commented 3 years ago

You're assigned! Let me know if you need any help 🙂

Pip7747 commented 2 years ago

Hi Davis, I would like to assign, thanks.

zdtsw commented 1 year ago

@Pip7747 you still work on this or should I unassign you?

Pip7747 commented 1 year ago

Hi WenZhouNo worries, please unassign me, recently working on a another project so haven’t get much time on this one.Sorry about it, appreciate.Regards Liz ------------------ Original ------------------From: Wen Zhou @.>Date: Thu, Nov 24, 2022 7:38 PMTo: adoptium/ci-jenkins-pipelines @.>Cc: Liz77 @.>, Mention @.>Subject: Re: [adoptium/ci-jenkins-pipelines] NODE_LABEL should be moreconfigurable (#33) @Pip7747 you still work on this or should I unassign you?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/adoptium/ci-jenkins-pipelines/issues/33#issuecomment-1326193267", "url": "https://github.com/adoptium/ci-jenkins-pipelines/issues/33#issuecomment-1326193267", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

adoptium / ci-jenkins-pipelines

NODE_LABEL should be more configurable #33