adoptium / ci-jenkins-pipelines

jenkins pipeline build scripts
Apache License 2.0
19 stars 71 forks source link

Fix: groovy linter warnings #428

Open zdtsw opened 2 years ago

zdtsw commented 2 years ago

To fix all the linter Warnings and preferable Info from GH action super-linter Goal: without any codenarc rule excluded , we should keep

┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │      0      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘

example run: https://github.com/adoptium/ci-jenkins-pipelines/actions/runs/3177396948/jobs/5177786644

Related: https://github.com/adoptium/ci-jenkins-pipelines/pull/427 and https://github.com/adoptium/ci-jenkins-pipelines/issues/425

zdtsw commented 2 years ago

Below are the warnings that cannot be auto-fixed: we might need to have a discussion to see if exclude or fix them: