search

adoptium / containers

Repo containing the dockerfiles and scripts to produce the official eclipse-temurin containers.
https://hub.docker.com/_/eclipse-temurin/
Apache License 2.0
206 stars 88 forks source link

migrate updater to use jinja templating #447

Closed gdams closed 8 months ago

gdams commented 8 months ago

Seems to be additions like:

amd64|i386:x86-64) \

     ESUM='7b175dbe0d6e3c9c23b6ed96449b018308d8fc94a5ecd9c0df8b8bc376c3c18a'; \

     BINARY_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.9%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.9_9.tar.gz'; \

     ;; \

     I suspect that should be split out?

I felt unsure what the best path forward was here. I think it makes sense to remove the dockerfile updates completely to make the PR easier to review