search

adoptium / containers

Repo containing the dockerfiles and scripts to produce the official eclipse-temurin containers.
https://hub.docker.com/_/eclipse-temurin/
Apache License 2.0
204 stars 87 forks source link

Add Ubuntu 24.04 Noble #534

Open poikilotherm opened 2 months ago

poikilotherm commented 2 months ago

I tested the generated Dockerfiles locally with my application, seems to work. Pushed it to GHCR for testing https://github.com/users/poikilotherm/packages/container/package/eclipse-temurin

Closes #532

I noticed that with Ubuntu 24.04 they added a default "ubuntu" user. Do you want to keep that one around or should it be deleted?

poikilotherm commented 2 months ago

How are the additional tags for 17-jre and others determined to be applied to which image builds? I wouldn't want anyone start using a not-yet-released version of Ubuntu and maybe some people rely on 17-jre to stay on the same OS version for some time...

alexander-yakushev commented 2 months ago

Hi! I noticed that Noble images are available now (pushed 10 hours ago): https://hub.docker.com/_/ubuntu/tags

root@240f07d544d6:/# cat /etc/issue
Ubuntu 24.04 LTS \n \l
gdams commented 2 months ago

@poikilotherm can you please also update https://github.com/adoptium/containers/blob/main/dockerhub_doc_config_update.sh#L42

MichalKoziorowski-TomTom commented 2 months ago

@sxa Ubuntu 24.04 noble is released now.

karianna commented 2 months ago

@sxa Did the PMC get a chance to meet and approve this version?

poikilotherm commented 3 weeks ago

Hi there @sxa @gdams, sorry for not being responsive. Was on a long vacation.

I updated this branch with the changes from main and commited the suggestion by @gdams.

I see lots of activity in lots of places at adoptium/infrastructure. I suppose merging this one will be put on hold until the failing tests are sorted out?

sxa commented 3 weeks ago

Hi there @sxa @gdams, sorry for not being responsive. Was on a long vacation.

No problem - I'm just back from about 2½ weeks too!

I updated this branch with the changes from main and commited the suggestion by @gdams.

👍🏻

I see lots of activity in lots of places at adoptium/infrastructure. I suppose merging this one will be put on hold until the failing tests are sorted out?

Yep they'll need to be analysed and understood/fixed before we'd be confident shipping this. https://github.com/adoptium/infrastructure/issues/3501 is where most of the triage/analysis is currently being done, although there seems to be quite a mix of failing tests there.

karianna commented 2 days ago

@sxa all tests pass now