adoptium / containers

Repo containing the dockerfiles and scripts to produce the official eclipse-temurin containers.
https://hub.docker.com/_/eclipse-temurin/
Apache License 2.0
204 stars 87 forks source link

Update documentation for CA certificate support changes #556

Open tellison opened 1 month ago

tellison commented 1 month ago

Check and update the "Can I add my internal CA certificates to the truststore?" section of the official image documentation to reflect the latest updates one they are published.

tellison commented 1 month ago

@rassie are you ok to take this task?

rassie commented 1 month ago

Yeah, sure, I wanted to have prepared a PR for that before the feature PR had been merged, but thought I had a bit more time, it has been accepted with less discussion than I anticipated. Will take a couple of days though, so if someone else would like to a stab before that, they are welcome to do so.

tellison commented 1 month ago

Yeah, sure, I wanted to have prepared a PR for that before the feature PR had been merged, but thought I had a bit more time, it has been accepted with less discussion than I anticipated. Will take a couple of days though, so if someone else would like to a stab before that, they are welcome to do so.

Apologies if it was merged sooner than expected. The PR was not draft and had undergone reviews and approvals. It can be reverted if you think it is not ready.

rassie commented 1 month ago

No no, it's fine. I just thought it would raise more discussions, but in the end seemed to be good enough.

rassie commented 1 month ago

Opened https://github.com/docker-library/docs/pull/2445.