search

adoptium / containers

Repo containing the dockerfiles and scripts to produce the official eclipse-temurin containers.
https://hub.docker.com/_/eclipse-temurin/
Apache License 2.0
204 stars 87 forks source link

Address comments on the "rootless CA certs" patch #572

Open rassie opened 4 weeks ago

rassie commented 4 weeks ago

Address the following problems with #538:

  1. Correct the shell selection for entrypoint, Ubuntu flavours still need explicit bash for variables with dots in their names
  2. Change unhelpful exported variable name (changed from CACERT to JRE_CACERTS_PATH)
  3. Change which to more-POSIX-compatible command -v
  4. More cleanup
  5. Explicitely use TMPDIR when available instead of hard-coded /tmp
rassie commented 4 weeks ago

Ubuntu flavours are broken, I'm on it.

karianna commented 4 weeks ago

CC @tianon

tianon commented 3 weeks ago

This is an improvement, yes, thanks :heart:

(definitely like your idea in #573 though, and wonder if, since this rootless functionality hasn't been officially released yet, it could happen sooner and then this is moot?)

rassie commented 3 weeks ago

wonder if, since this rootless functionality hasn't been officially released yet, it could happen sooner and then this is moot?

That's my thinking too, but since I'm not involved in and not knowledgeable about the release process and its deadlines, I'm offerring both possibilities. #573 still needs to be implemented, tested, documented and experimented with after all and if "July release" is what I think it is, the timeline is rather tight. "rootless" improves on the current process, which is probably valuable by itself, even if we know how it could be improved further.

rassie commented 6 days ago

@karianna Are you aware of anything blocking the review and merge here? I would like to get this in before the July release as QOL improvement.

karianna commented 2 days ago

@sxa and/or @gdams up next to review and merge.