search

adoptium / github-release-scripts

Scripts for release artefacts to GitHub releases
Apache License 2.0
6 stars 20 forks source link

Add release notes filter to UploadFiles.groovy #113

Closed sxa closed 1 year ago

sxa commented 1 year ago

refactor_openjdk_release_tool is currently unable to publish the release notes because there is an additional filter in the UploadFiles.groovy script on top of the one that's in the jenkins job. This fixes that problem.

sxa commented 1 year ago

Requesting reviews from people who've been near this part of the code :-)

sxa commented 1 year ago

(NOTE to reviewers: I've tested this and it allows the release notes to be published - the one that was failing for me is now at https://github.com/adoptium/temurin18-binaries/releases/download/jdk-18.0.2.1%2B1/OpenJDK18U-jdk-release-notes_18.0.2.1_1.json which was uploaded using this change)

sxa commented 1 year ago

This should be the final piece of the jigsaw that's required for the release notes. - @steelhead31 we should get this generation and publishing integrated into the release processes docs now too and aim to do it in a timely fashion for JDK20 :-)

steelhead31 commented 1 year ago

This should be the final piece of the jigsaw that's required for the release notes. - @steelhead31 we should get this generation and publishing integrated into the release processes docs now too and aim to do it in a timely fashion for JDK20 :-)

I've added some relevant line items in to the release checklist PR thats currently in review status. I plan to update the RELEASING document at some point with more detail for each of the checklist items, once I've got the checklist finalised too.

sxa commented 1 year ago

Ref: https://github.com/adoptium/temurin-build/issues/3044