adoptium / github-release-scripts

Scripts for release artefacts to GitHub releases
Apache License 2.0
6 stars 20 forks source link

releaseCheck: fix non-POSIX syntax for Alpine #146

Closed sxa closed 7 months ago

sxa commented 7 months ago

Removes bash-specific syntax.

Unlike me to make this sort of error as I'm generally quite picky about it :-) The problem didn't show up on my development Fedora system but has an issue on Linux systems using dash by default.

Fixes #145 Also referred to in https://github.com/adoptium/temurin/issues/13#issuecomment-1900826057

sxa commented 7 months ago

/merge

github-actions[bot] commented 7 months ago

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

jerboaa commented 7 months ago

/approve

gdams commented 7 months ago

/approve

sxa commented 7 months ago

@jerboaa Can you do a "normal" approval on the PR too please as it needs a second to allow me to merge.

Never mind - thanks @tellison !