Nightly builds page offering last successful build's binary for each date

[ben-walsh]

For example, the nightly build of Linux x64 platform was last successful here - https://ci.adoptopenjdk.net/job/openjdk8_openj9_build_x86-64_linux/62. Every subsequent build has failed to date.

Yet the nightly build page (https://adoptopenjdk.net/nightly.html?variant=openjdk8-openj9) currently offers binaries (with different dated names) for all the dates it failed - they are actually the same binary from the last successful build ...

ben@ben-ThinkPad-W530:~$ ls -l OpenJDK8*.tar.gz
-rw-r--r-- 1 ben ben 82471252 Feb  9 14:01 OpenJDK8-OPENJ9_x64_Linux_20180902.tar.gz
-rw-r--r-- 1 ben ben 82471252 Feb 13 14:01 OpenJDK8-OPENJ9_x64_Linux_20181302.tar.gz
ben@ben-ThinkPad-W530:~$ diff OpenJDK8-OPENJ9_x64_Linux_20180902.tar.gz  OpenJDK8-OPENJ9_x64_Linux_20181302.tar.gz
ben@ben-ThinkPad-W530:~$ 

I've not checked whether this is the case across platforms and VM variants.

[sxa]

https://ci.adoptopenjdk.net/job/openjdk9_openj9_build_checksum/ (which is used as input to https://ci.adoptopenjdk.net/view/Tooling/job/openjdk_release_tool/) is pulling from the "last successful build" instead of the last build, which explains why this is happening.

Suspect the checksum job will need to handle the case where the job failed and only allow creation of checksums and publishing of things that are actually new builds.

[karianna]

@johnoliver I think the API overrules this now right?

[karianna]

@johnoliver ^^