search

adoptium / github-release-scripts

Scripts for release artefacts to GitHub releases
Apache License 2.0
6 stars 20 forks source link

Ability to pass in GITHUB_SERVER and GITHUB_ORG params #75

Closed AdamBrousseau closed 3 years ago

AdamBrousseau commented 3 years ago

Default to Github.com and AdoptOpenJDK if not passed.

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

AdamBrousseau commented 3 years ago

Updated. Tested on my side. Seems to still work. Please review.

AdamBrousseau commented 3 years ago

Added 2 print lines. Made server and org optional params of the groovy that are defaulted to the current Adopt values.

tellison commented 3 years ago

Approval to merge during the lockdown cycle please

gdams commented 3 years ago

Approval to merge during the lockdown cycle please

+1

tellison commented 3 years ago

@sxa please give a reason with your -1 vote.

sxa commented 3 years ago

@sxa please give a reason with your -1 vote.

Sorry - typed a reason but apparently didn't press the comment button. @karianna indicated in slack that this wasn't a blocker for @AdamBrousseau therefore there is no reason to break the code freeze for this as far as I'm aware.

AdamBrousseau commented 3 years ago

Sorry, yes, I have this added on my fork so no need to merge before the release.

tellison commented 3 years ago

OK. This may get forgotten over the course of the release, so please ping it up again if it doesn't get actioned after the code thaw. Thanks for the enhancement.