adoptium / github-release-scripts

Scripts for release artefacts to GitHub releases
Apache License 2.0
6 stars 20 forks source link

Request to bump to latest version of kohsuke:github-api #76

Closed AdamBrousseau closed 3 years ago

AdamBrousseau commented 3 years ago

Currently at 1.95. Latest release is 1.127 https://github.com/adoptium/github-release-scripts/blob/435bc9d2175f596c380de3a9f0bbbdf0cdb19368/adopt-github-release/build.gradle#L18

That version has a hardcoded upload url for release assets which blocks me from uploading to a GHE server. https://github.com/hub4j/github-api/blob/c1bab63ebdd9c93e49a5879331234de488e91590/src/main/java/org/kohsuke/github/GHRelease.java#L140

I tried this version on my fork and it seems to work. I'm not sure what else would need to be tested in order to accept the change.