search

adoptium / github-release-scripts

Scripts for release artefacts to GitHub releases
Apache License 2.0
6 stars 20 forks source link

update: abort program if strip fullpath in sha256.txt failed #91

Closed zdtsw closed 1 year ago

zdtsw commented 2 years ago

Since we do not know how often this really happens, because it is only the installer job for release encounter such issue. For the temp. workaround is to make the release job failed so we can see what exactly cause this if the expression is wrong or we get extra char in the file not matching it. then we can modify the script to have less failure.

Ref: https://github.com/adoptium/temurin-build/issues/2865

zdtsw commented 2 years ago

IMHO We really need to track this down and fix the underlying problem. Trapping it at this stage will still lead to extra manual error-prone work being required.

yeah, this is not for fixing the problem, only to give us some hints if this happens all the times, because we do not check nightly build all the time and problem only seen for the release installer failure. also when it failed we can see what exactly went wrong for these files.

sxa commented 2 years ago

The check as implemented is also incredible crude and only checks for one possible failure. If we're going to trap a dodgy sha256sum file here it should be by running sha256sum -c against it to see if it works - that would fail if either the checksum is incorrect, or the path inside it was wrong.

karianna commented 1 year ago

@zdtsw Should we close this PR?

zdtsw commented 1 year ago

@zdtsw Should we close this PR?

sure, can do dont think I will work on this in the near future