search

adoptium / installer

Installer scripts for Eclipse Temurin binaries
Apache License 2.0
149 stars 75 forks source link

[RPM] man pages not linked properly for jre package temurin17 #629

Open andrlos opened 1 year ago

andrlos commented 1 year ago

Hi, so the issue is reproducible by: 1)installing temurin-17-jre rpm package 2) calling "man java"

-the cause of this problem is the lack of "--slave" declaration for jre manpages in postinstall scriptlet of the rpm, thus missing links to the installed manpages (the scriptlets can be checked by calling "rpm -qp --scripts pkgname")

another problem is that manpages are missing in temurin-17-jre altogether

refer to the difference in jdk vs jre package in this matter or jre of different major version e.g.11

andrlos commented 1 year ago

its also notable that manpages are not when they should be altogether.. the customary place to store them is in /usr/share/man/man1 and not in /usr/lib/jvm/temurin-$ver-$subpkg/man/man1 .. is there a particular reason for this difference to the common convention? Thanks!

zdtsw commented 1 year ago

maybe @ascheman have some insights?

ascheman commented 1 year ago

The core problem might be that the JRE tarballs for Temurin-17 do not contain man files (nor Temurin-19 and presumably Temurin-20).

jiekang commented 1 year ago

Worth exploring:

The JRE spec files don't have the alternative --slave entries like the JDK spec files do for the manpages. They probably should.

JDK: https://github.com/adoptium/installer/blob/master/linux/jdk/redhat/src/main/packaging/temurin/20/temurin-20-jdk.spec#L159

JRE: https://github.com/adoptium/installer/blob/master/linux/jre/redhat/src/main/packaging/temurin/20/temurin-20-jre.spec