search

adoptium / jenkins-helper

Jenkins Node helper API and helper jobs
Apache License 2.0
8 stars 26 forks source link

fix: update clean workspace param #43

Open sakshi1215 opened 2 years ago

sakshi1215 commented 2 years ago

Reference https://github.com/adoptium/ci-jenkins-pipelines/pull/440/files

Ref: https://github.com/adoptium/ci-jenkins-pipelines/issues/433

sakshi1215 commented 2 years ago

@zdtsw @karianna Can you please review this?

sakshi1215 commented 2 years ago

Can we merge this @karianna & @zdtsw ?

zdtsw commented 2 years ago

We could have this one merged but any ongoing build will fail immediately with so many calls to the helper. Then to have https://github.com/adoptium/ci-jenkins-pipelines/pull/440 merged in, which requires re-run all pipelines to get a clean view of how quality is before CPU. I leave the decision to others either to merge both PRs before I can declare code freeze or put it on "post-release"

karianna commented 2 years ago

Let's put this in draft and merge post release week.