search

adoptium / jenkins-helper

Jenkins Node helper API and helper jobs
Apache License 2.0
7 stars 26 forks source link

Stop adding NODE_LABEL to build job parameters #53

Closed andrew-m-leonard closed 1 year ago

andrew-m-leonard commented 1 year ago

Fixes: https://github.com/adoptium/infrastructure/issues/2774#issuecomment-1494192694

karianna commented 1 year ago

Please change title of the commit to NODE_LABEL (i.e. remove the extra L

Changed it (FYI - you also have that power in the UI going forwards)

sxa commented 1 year ago

Please change title of the commit to NODE_LABEL (i.e. remove the extra L

Changed it (FYI - you also have that power in the UI going forwards)

Fair point :-) I usually prefer to get the review first and do it myself, but in this case it was obvious and noncontroversial enough that Is probably have just done it. Thanks

andrew-m-leonard commented 1 year ago

I reckon, this IS needed to schedule the build jobs, suspect we should be defining the job template with NODE_LABEL instead

andrew-m-leonard commented 1 year ago

Close in favour of new PR https://github.com/adoptium/jenkins-helper/pull/55