Remove NODE_LABEL from build job params - Githubissues

adoptium / jenkins-helper

Jenkins Node helper API and helper jobs

Apache License 2.0

7 stars 26 forks source link

Remove NODE_LABEL from build job params #55

Closed andrew-m-leonard closed 1 year ago

andrew-m-leonard commented 1 year ago

Fixes https://github.com/adoptium/ci-jenkins-pipelines/issues/312

Issue https://github.com/adoptium/ci-jenkins-pipelines/pull/101/files originally remove the NODE_LABEL from the create build job template, as it is correctly not needed, since the openjdk pipelines use node() context to achieve the same here: https://github.com/adoptium/ci-jenkins-pipelines/blob/bc206dcf5aab5ebba3f081a55533c9313fc5cefb/pipelines/build/common/openjdk_build_pipeline.groovy

However the jenkins-helper IndividualBuildConfig.toBuildParams() was still adding it to the job invocation, thus causing the Jenkins log error...

andrew-m-leonard commented 1 year ago

Successful test with no NODE_LABEL: https://ci.adoptium.net/job/build-scripts/job/openjdk20-pipeline/207/console