search

adoptium / marketplace-api.adoptium.net

Adoptium Marketplace API 🚀
https://marketplace-api.adoptium.net
Apache License 2.0
4 stars 4 forks source link

MarketPlace data binary.package.sha265sum name incorrect #542

Open andrew-m-leonard opened 2 weeks ago

andrew-m-leonard commented 2 weeks ago

binary.package.sha265sum should be sha256sum

Currently the Asset definition and numerous examples and code use the same typo: https://github.com/search?q=org%3Aadoptium%20sha265sum&type=code

Some vendors have assumed the correct spelling, eg. https://github.com/rh-openjdk/marketplace/blob/8a48a422ad38b5af4fafb51c72ea001ed17eb895/21/jdk_21_0_5.json#L30

andrew-m-leonard commented 2 weeks ago

Explains why Checksum field is blank in the marketplace for Red Hat and Microsoft: https://adoptium.net/marketplace/?version=21&os=linux&arch=x64,

tellison commented 1 week ago

@johnoliver unless you have other ideas, it seems that 'fixing' this field name will break some vendors' existing data - so we can either (a) co-ordinate with vendors and push a fix at the same time vendors regenerate/resign their information, or (b) support the wrong and correct field name for a limited time to allow transition.

johnoliver commented 1 week ago

Yes we unfortunately need to support both to avoid an API breaking change, done a PR at:

https://github.com/adoptium/marketplace-api.adoptium.net/pull/553

Unfortunately this goes beyond just the vendors, the public API also had the typo so needs to be supported for backwards compatibility