search

adoptium / openj9-systemtest

Long running J9 tests
Other
6 stars 38 forks source link

Fix line-ends and remove trailing whitespace #131

Closed keithc-ca closed 3 years ago

Mesbah-Alam commented 3 years ago

This PR also seems to fail in the Line Endings Check : https://ci.eclipse.org/openj9/job/PullRequest-LineEndingsCheck-Systemtest/175/console

keithc-ca commented 3 years ago

Yes, I noticed that. I'm trying to figure out why pull requests for this repo work differently as compared to, say, openj9.

keithc-ca commented 3 years ago

I expect the problem is this line in .gitattributes:

* text eol=lf

I updated that file as well, but as yet it doesn't seem to be helping.

keithc-ca commented 3 years ago

Jenkins line endings check

keithc-ca commented 3 years ago

@AdamBrousseau Any theories why the line-end check is failing even after removing the 'eol' specification from .gitattributes (like openj9)?

keithc-ca commented 3 years ago

Does the check require a good version of .gitattributes on the default branch?

AdamBrousseau commented 3 years ago

Looks like it's complaining about the bat file.

ERROR - should have CRLF line terminators: 'openj9.build/scripts/openj9-systemtest-clone-make.bat' type: 'ASCII text'
keithc-ca commented 3 years ago

Ok, I needed to commit the change locally to .gitattributes before committing the change to the *.bat file: the check has now passed.