Add ED sign embedded trailing corner cases

adoptium / openj9-systemtest

Long running J9 tests

Other

5 stars 37 forks source link

Add ED sign embedded trailing corner cases #133

Closed VermaSh closed 3 years ago

VermaSh commented 3 years ago

Packed decimal to external decimal conversion corner cases:

Max precision for preferred and alternate sign
Non 0 packed decimal offset
- ending at the sign byte
- ending at non sign byte

Signed-off-by:Shubham Verma shubhamv.sv@gmail.com

VermaSh commented 3 years ago

@fjeremic this almost ready for review. ~I just need to duplicate these corner case tests for sign separate trailing, sign separate leading and sign embedded leading.~ I'll open another PR for those tests.

fjeremic commented 3 years ago

Looks good. @VermaSh could you fix the copyright?

VermaSh commented 3 years ago

@fjeremic I have updated the copyright year but the test is still failing. Not sure if we need to update something or just need to rerun the test.

VermaSh commented 3 years ago

@fjeremic Copyright should be good now.

fjeremic commented 3 years ago

@llxia any testing to launch here before we merge?

llxia commented 3 years ago

@Mesbah-Alam could help to run Grinder to test these daa tests? Thanks

Mesbah-Alam commented 3 years ago

Hi @fjeremic , TestPD2ED.java is part of daa2 load, which is exercised by DaaLoadTest_daa2_5m.

Started a grinder for DaaLoadTest_daa2_5m using Shubham's branch here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1059/console

Please re-run this grinder to further test your changes, if needed.

fjeremic commented 3 years ago

Grinder looks good and we've tested internally as well. Proceeding with the merge. Thanks all!