Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots()

annaibm commented 3 months ago

SharedClasses tests to generate related classes under workspace dir - with getResultsDir function instead of getPrereqRoots.

annaibm commented 3 months ago

Grinder links: m/c:rtj-ubu24x86-svl-test-qvfxt-1.fyre.ibm.com https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41046/rebuild/parameterized -jdk17 https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41047/rebuild/parameterized -jdk11

TARGET: extended.system https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41048/ with following PR branches- aqatest:5361, TKG: 562, STF: 138

https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41051/ without the PRs Branches i.e. on master branch

llxia commented 3 months ago

@annaibm can you date the title to Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots()?

llxia commented 3 months ago

Can you also run extended.system on windows?

llxia commented 3 months ago

Just for the record, in order to pre-stage 3rd party system test jars change, getPrereqRoots() cannot be used for storing generated test data. This PR changes to use getResultsDir(), which changes the current behavior.

current behavior: sharedClassesTestData is generated under one fixed dir /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/. For example, if SharedClasses.SCM01.SingleCL generates sharedClassesTestData. It will be used for other SharedClasses tests (i.e., SharedClasses.SCM23.SingleCL, SharedClasses.SCM01.MultiCL, SharedClasses.SCM23.MultiCL, SharedClasses.SCM01.MultiThreadMultiCL, etc). Instead of Step 1 - Create Shared Classes jars, they will do Step 1 - Copy sharedClasses jar.
new behavior: since each test will generate sharedClassesTestData under its test result dir (i.e., /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_17171870437914/SharedClasses.SCM23.MultiCL_0/20240531-165032-SharedClasses/results/). Each test will generate its own sharedClasses jar.

I believe this new behavior does not change the actual tests. It will make the test more self contained.

annaibm commented 3 months ago

re https://github.com/eclipse-aqavit/openj9-systemtest/pull/154#issuecomment-2145384051

Grinder link:

https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41069/

adoptium / openj9-systemtest

Store sharedClassesTestData using getResultsDir() instead of getPrereqRoots() #154