search

adoptium / openj9-systemtest

Long running J9 tests
Other
6 stars 38 forks source link

Correct shared library suffix on macOS #158

Closed keithc-ca closed 2 months ago

keithc-ca commented 2 months ago

Should fix failure seen in https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_extended.system_aarch64_mac_Release/86.

pshipton commented 2 months ago

I'm not sure why we need this or what side affects it might have. There is no failure in the head stream. https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_extended.system_aarch64_mac_Release/86 is failing on the 0.48 release because https://github.com/eclipse-openj9/openj9/pull/20202 isn't delivered there yet.

pshipton commented 2 months ago

This change breaks the test on Mac. I will revert it. Agent library /Users/jenkins/workspace/Grinder/jvmtest/system/openj9-systemtest/openj9.test.sharedClasses.jvmti/bin/native/osx/libsharedClasses.dylib could not be opened (dlopen(/Users/jenkins/workspace/Grinder/jvmtest/system/openj9-systemtest/openj9.test.sharedClasses.jvmti/bin/native/osx/libsharedClasses.dylib, 1): image not found)

pshipton commented 2 months ago

Reverted via https://github.com/adoptium/openj9-systemtest/pull/159

keithc-ca commented 2 months ago

This change was incomplete. I'll create a proper replacement shortly.

pshipton commented 2 months ago

Pls make new changes as draft until they are tested.