search

adoptium / openj9-systemtest

Long running J9 tests
Other
6 stars 38 forks source link

Use shorter path for cacheDir since on Windows MAX_PATH is 260 #80

Closed Mesbah-Alam closed 5 years ago

Mesbah-Alam commented 5 years ago

Signed-off-by: Mesbah_Alam@ca.ibm.com Mesbah_Alam@ca.ibm.com

Mesbah-Alam commented 5 years ago

Related: https://github.com/eclipse/openj9-systemtest/issues/75#issuecomment-458185307:

"The length of path "C:\Users\jenkins\workspace\Test-extended.system-JDK8-win_x86-64_cmprssptrs\openjdk-tests\TestConfig\test_output_15477678633841\SharedClassesAPI_0\20190117-174310-SharedClassesAPI\results\caches\javasharedresources\C290M4F1A64_DefinedLocationGroupAccessJavaWL4_G35" is 262, which is greater than MAX_PATH(=260) on Windows. The cacheDir/cacheName is too long. The test needs to be updated to use a shorter cacheDir/cacheName."

Mesbah-Alam commented 5 years ago

What's done in this PR:

In order to keep length of cache dir within 260 chars, 1) Cache Dir can simply be the test directory (changed);

  1. Name of cache is defined using Test names that are defined in the enum Tests. We can make these names a bit shorter, without compromising on readability.(done).
Mesbah-Alam commented 5 years ago

@hangshao0 - FYI.

Mesbah-Alam commented 5 years ago

@smlambert - could you please review and merge this PR?

Mesbah-Alam commented 5 years ago

Tested on Windows using internal Jenkins (link shared on Slack).

Mesbah-Alam commented 5 years ago

Teated on Linux here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/926/console