Window system tests do not build for the 0.12 release

[pshipton]

https://ci.eclipse.org/openj9/job/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/154 https://ci.eclipse.org/openj9/job/Test-extended.system-JDK11-win_x86-64_cmprssptrs/153

19:14:14 build-natives-windows:
19:14:14      [exec] 
19:14:14      [exec] C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdk-tests\systemtest\openjdk-systemtest\openjdk.test.modularity>call "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\vcvarsall.bat" amd64   && make -C C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdk-tests\systemtest\openjdk-systemtest/openjdk.test.modularity/src/tests/com.test.jlink/native SRC=JniTest PLATFORM=win_x86-64 JAVA_HOME=C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdkbinary\j2sdk-image\ OUTDIR=C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdk-tests\systemtest\openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/bin HEADERDIR=C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdk-tests\systemtest\openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/lib OSNAME=win 
19:14:14      [exec] Setting environment for using Microsoft Visual Studio 2010 x64 tools.
19:14:14      [exec] make[1]: Entering directory '/cygdrive/c/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/src/tests/com.test.jlink/native'
19:14:14      [exec] makefile:224: JAVA_EXECUTABLE set to C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdkbinary\j2sdk-image\/bin/java/.exe
19:14:14      [exec] mkdir -p C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/bin/win_x86-64
19:14:14      [exec] mkdir -p C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/lib/win_x86-64
19:14:14      [exec] cmd /c cl /DWIN32 /D_WINDOWS -Gy /LD /Zi /Odi /c /RTC1 /Fo"C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/lib/win_x86-64/JniTest.obj" /Fd"C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/lib/win_x86-64/win_x86-64" /I. /I"C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdk-tests\systemtest\openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/lib" /I"C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdkbinary\j2sdk-image\/../include" /I"C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdkbinary\j2sdk-image\/../include/win32" /I"C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdkbinary\j2sdk-image\/include" /I"C:\Users\jenkins\workspace\Test-sanity.system-JDK11-win_x86-64_cmprssptrs\openjdkbinary\j2sdk-image\/include/win32" JniTest.c
19:14:15      [exec] Microsoft (R) C/C++ Optimizing Compiler Version 16.00.40219.01 for x64
19:14:15      [exec] JniTest.c
19:14:15      [exec] Copyright (C) Microsoft Corporation.  All rights reserved.
19:14:15      [exec] 
19:14:16      [exec] cmd /c link /NOLOGO /DLL /INCREMENTAL:NO /NODEFAULTLIB:LIBCMTD /OUT: C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/bin/win_x86-64/JniTest.dll C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/lib/win_x86-64/JniTest.obj
19:14:16      [exec] LINK : fatal error LNK1146: no argument specified with option '/OUT:'
19:14:16      [exec] make[1]: Leaving directory '/cygdrive/c/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/src/tests/com.test.jlink/native'
19:14:16      [exec] make[1]: *** [makefile:239: C:/Users/jenkins/workspace/Test-sanity.system-JDK11-win_x86-64_cmprssptrs/openjdk-tests/systemtest/openjdk-systemtest/openjdk.test.modularity/bin/tests/com.test.jlink/native/bin/win_x86-64/JniTest.dll] Error 122
19:14:16 
19:14:16 BUILD FAILED

[pshipton]

@smlambert anything we can do to quickly fix this?

[pshipton]

Possibly related to @Mesbah-Alam adding a space to the -o command for osx.

[smlambert]

We can revert https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/220 . I understood it was merged because without it, native tests might fail on certain osx machines (due to lack of space), so its less problematic perhaps than always failing on windows.

@Mesbah-Alam is about to leave on vacation (tomorrow), so perhaps it can be the last thing he looks at before he heads out.

[pshipton]

@smlambert please go ahead and revert. I agree osx failing to build sometimes is better than always failing on Windows. Plus the osx jobs for the 0.12 release have already run.

[Mesbah-Alam]

Thanks for reverting my PR @smlambert - The error on Windows was obviously not anticipated by me when preparing this PR for osx.

There was a PR delivered by Simon to initially get this test to compile on Windows - https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/217. This PR introduced the absence of space after -o - which one of the test osx machines seems to not like.

https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/220 added that space only (leaving all the rest of Simon's changes as is) - but that seems to have taken us back to the Windows error again. We need to figure out why that space is not liked on Windows - or may be add that space while on OSX only.

[pshipton]

Right, we need the space on osx only. Windows syntax doesn't include a space.

[Mesbah-Alam]

I am testing the PR.