adoptium / run-aqa

Repository for the Github Action that enables the running of the Adoptium Quality Assurance (AQA) tests
MIT License
3 stars 27 forks source link

Add option to pass in openj9 systemtest repo and branch #94

Open sophia-guo opened 3 years ago

sophia-guo commented 3 years ago

Currently we are using the default eclipse-openj9/openj9-systemtest to run against openj9 java implementation. It would be nice to add eclipse-openj9/openj9-systemtest repo and branch as options. So run-aqa action can also be used as the part of eclipse-openj9/openj9-systemtest developer's PR tests.

somya-15 commented 2 years ago

Can I (Somya-15) and Nandini(nandini-4120) be assigned this issue. We are willing to collaborate on this issue.

smlambert commented 2 years ago

I can assign you if you make a comment in the issue, @nandini-4120

smlambert commented 2 years ago

Note the solution to this will be similar to PR #102 and PR #103

Nandini-4120 commented 2 years ago

Can I Nandini(nandini-4120) be assigned this issue? Somya and me are willing to collaborate on this issue.

somya-15 commented 2 years ago

Hi, I(somya-15) and Nandini(Nandini-4120) collaborated on this single issue. Kindly consider us as contributors for the PR. Should both of us fill the ECA agreement?

smlambert commented 2 years ago

Yes, both need the ECA agreement signed, and the PR should use the "Co-authored-by" keyword so that both authors get credited for the change.

(related doc: https://docs.github.com/en/github/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)

somya-15 commented 2 years ago

Kindly suggest changes/corrections that we can make in the PR as we are unable to pass 3 tests as shown below: Screenshot 2021-10-12 at 15 34 25

smlambert commented 2 years ago

related: https://github.com/adoptium/run-aqa/pull/107

smlambert commented 2 years ago

The PR https://github.com/adoptium/run-aqa/pull/107 was closed without being merged. Un-assigning and putting it back into the list of open / available good first issues.

somya-15 commented 2 years ago

Can I (Somya-15) and Nandini(nandini-4120) be assigned this issue again as we are planning to make a fresh pull request and start over again.